Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braindecode and Moabb dataset #663

Open
bruAristimunha opened this issue Oct 17, 2024 · 5 comments
Open

Braindecode and Moabb dataset #663

bruAristimunha opened this issue Oct 17, 2024 · 5 comments

Comments

@bruAristimunha
Copy link
Collaborator

bruAristimunha commented Oct 17, 2024

The following datasets are not working with the braindecode loader:

  • <class 'moabb.datasets.epfl.EPFLP300'>
  • <class 'moabb.datasets.hinss2021.Hinss2021'>
  • <class 'moabb.datasets.huebner_llp.Huebner2017'>
  • <class 'moabb.datasets.huebner_llp.Huebner2018'>
  • <class 'moabb.datasets.schirrmeister2017.Schirrmeister2017'>
@bruAristimunha
Copy link
Collaborator Author

bruAristimunha commented Oct 21, 2024

  • <class 'moabb.datasets.epfl.EPFLP300'>
  • <class 'moabb.datasets.mpi_mi.GrosseWentrup2009'>
  • <class 'moabb.datasets.hinss2021.Hinss2021'>
  • <class 'moabb.datasets.huebner_llp.Huebner2017'>
  • <class 'moabb.datasets.huebner_llp.Huebner2018'>
  • <class 'moabb.datasets.liu2024.Liu2024'>
  • <class 'moabb.datasets.mpi_mi.MunichMI'>
  • <class 'moabb.datasets.upper_limb.Ofner2017'>
  • <class 'moabb.datasets.physionet_mi.PhysionetMI'>
  • <class 'moabb.datasets.schirrmeister2017.Schirrmeister2017'>
  • <class 'moabb.datasets.sosulski2019.Sosulski2019'>
  • <class 'moabb.datasets.Zhou2016.Zhou2016'>

@bruAristimunha
Copy link
Collaborator Author

Less that I expected :)

@bruAristimunha
Copy link
Collaborator Author

bruAristimunha commented Oct 23, 2024

The issue with EPFLP300 is the irregular size of events in the raw data in the last events. Initially, I thought it was the case where drop_bad would solve it, but no. In some sessions, we have different values.

I tried to solve it on the braindecode side for half an hour, but I couldn't. I'll come back to this later, but on the moabb side.

Same issue with Hinss2021:

assert np.all(this_trial_sizes == window_size_samples), (

AssertionError: All trial sizes should be the same if you do not supply a window size.

@bruAristimunha
Copy link
Collaborator Author

Huebner2017 has an issue too.

@PierreGtch
Copy link
Collaborator

@bruAristimunha

Couls this be related to braindecode/braindecode#563 and #607 ?

Now the annotations should always be set on raw moabb datasets thanks to the SetAnnotations step:

SetRawAnnotations(
self.event_id,
interval=self.interval,
),

But if the raw already has annotations, this step is skipped:

if raw.annotations:
return raw

I think we should overwrite the annotations' durations, even if they are already set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants