Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexSeries should have the unit 'N/A' and have uint32 data #458

Closed
rly opened this issue Aug 5, 2020 · 1 comment · Fixed by #459
Closed

IndexSeries should have the unit 'N/A' and have uint32 data #458

rly opened this issue Aug 5, 2020 · 1 comment · Fixed by #459

Comments

@rly
Copy link
Contributor

rly commented Aug 5, 2020

  1. The unit attribute is meaningless for the IndexSeries type. "The data field stores the index of the frame in the referenced ImageSeries, and timestamps array indicates when that image was displayed."

  2. The data dataset of IndexSeries is int32. It should be uint32 since negative frame indices makes no sense.
@rly
Copy link
Contributor Author

rly commented Aug 5, 2020

The conversion and resolution attributes are also meaningless for IndexSeries.

This was referenced Aug 5, 2020
Merged
Merged
@rly rly closed this as completed in #459 Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul IndexSeries and add "order_of_images" to Images NeurodataWithoutBorders/nwb-schema
1 participant
@rly