Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for electrodes #1237

Closed
rly opened this issue May 18, 2020 · 0 comments · Fixed by #1272
Closed

Fix documentation for electrodes #1237

rly opened this issue May 18, 2020 · 0 comments · Fixed by #1272
Assignees
@rly
Labels
category: bug errors in the code or code behavior

Comments

@rly
Copy link
Contributor

rly commented May 18, 2020 •
edited
Loading

See AllenInstitute/AllenSDK#1482 (comment)

  1. The description to ElectrodeTable should be 'Add an electrode to the electrodes table' not 'Add a unit to the unit table'
  2. The imp documentation should specify units of 'ohms'. nwb-schema should also be updated.
  3. The filtering documentation should specify that at least the name and frequency cutoffs of the filters should be included. nwb-schema should also be updated.
@rly rly added the category: bug errors in the code or code behavior label May 18, 2020
@rly rly self-assigned this May 18, 2020
This was referenced Jul 30, 2020
Merged
Merged
@rly rly closed this as completed in #1272 Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rly rly

Labels
category: bug errors in the code or code behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify docstrings for electrode table NeurodataWithoutBorders/pynwb
1 participant
@rly