Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection leak due to HttpClient instantiation without an HttpClientFactory #19

Open
KeithHenry opened this issue Jul 4, 2023 · 1 comment · May be fixed by #20
Open

Connection leak due to HttpClient instantiation without an HttpClientFactory #19

KeithHenry opened this issue Jul 4, 2023 · 1 comment · May be fixed by #20

Comments

@KeithHenry
Copy link

This line creates a HttpClient every time the service is created:

This will cause more HTTP connections being opened, and left open as this connection isn't closed or disposed either.

This needs an HttpClientFactory to avoid the connection leak.

@KeithHenry
Copy link
Author

This is fixed in our fork EvolutionJobs#3

#20 applies those changes back here.

@KeithHenry KeithHenry changed the title Connection link due to HttpClient instantiation without an HttpClientFactory Connection leak due to HttpClient instantiation without an HttpClientFactory Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant