Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

(DEV-4095) Fixes Confusing clicking of notes #307

Merged
merged 6 commits into from
Oct 14, 2019
Merged

Conversation

redreceipt
Copy link
Contributor

@redreceipt redreceipt commented Oct 14, 2019

DESCRIPTION

What does this PR do, or why is it needed?

Now in a header or text feature, if a note is not a fill in the blank or has already been clicked, you can't click it again.

How do I test this PR?

Go to "Loving Conversations" in "Elephant in the Room" in alpha

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@redreceipt redreceipt added the ready for review This is ready to be reviewd label Oct 14, 2019
@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@c3d718d). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #307   +/-   ##
==========================================
  Coverage           ?   44.26%           
==========================================
  Files              ?      157           
  Lines              ?     1473           
  Branches           ?      154           
==========================================
  Hits               ?      652           
  Misses             ?      728           
  Partials           ?       93
Impacted Files Coverage Δ
...urchapp/src/content-single/Features/TextFeature.js 26.66% <0%> (ø)

@redreceipt redreceipt changed the title Fixes Confusing clicking of notes (DEV-4095) Fixes Confusing clicking of notes Oct 14, 2019
@richarddubay richarddubay merged commit 414c937 into develop Oct 14, 2019
@richarddubay richarddubay deleted the clickable-notes branch October 14, 2019 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review This is ready to be reviewd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants