Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

(DEV-3843) Fixes infinite loading children #310

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

vinnyjth
Copy link
Contributor

DESCRIPTION

What does this PR do, or why is it needed?

How do I test this PR?

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@redreceipt
Copy link
Contributor

thank you! must have missed in the merge

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@575623f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #310   +/-   ##
==========================================
  Coverage           ?   44.32%           
==========================================
  Files              ?      157           
  Lines              ?     1471           
  Branches           ?      154           
==========================================
  Hits               ?      652           
  Misses             ?      726           
  Partials           ?       93
Impacted Files Coverage Δ
.../src/content-single/HorizontalContentFeed/index.js 69.23% <ø> (ø)

@redreceipt redreceipt self-requested a review October 14, 2019 18:37
@redreceipt redreceipt added the merge When the tests pass, merge! label Oct 14, 2019
@redreceipt redreceipt changed the title Fixes infinite loading children (DEV-3843) Fixes infinite loading children Oct 14, 2019
@redreceipt redreceipt merged commit c3d718d into develop Oct 14, 2019
@redreceipt redreceipt deleted the fix-infinite-loading-children branch October 14, 2019 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge When the tests pass, merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants