Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Upgrades to Apollos 1.2.0-beta.6 #326

Merged
merged 14 commits into from
Oct 21, 2019
Merged

Upgrades to Apollos 1.2.0-beta.6 #326

merged 14 commits into from
Oct 21, 2019

Conversation

redreceipt
Copy link
Contributor

DESCRIPTION

What does this PR do, or why is it needed?

How do I test this PR?

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@redreceipt redreceipt added the ready for review This is ready to be reviewd label Oct 21, 2019
@codecov-io
Copy link

Codecov Report

Merging #326 into develop will decrease coverage by 0.08%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #326      +/-   ##
===========================================
- Coverage    43.93%   43.85%   -0.09%     
===========================================
  Files          157      157              
  Lines         1493     1496       +3     
  Branches       157      157              
===========================================
  Hits           656      656              
- Misses         742      745       +3     
  Partials        95       95
Impacted Files Coverage Δ
...es/newspringchurchapp/src/ui/WebBrowser/Browser.js 16.66% <ø> (ø) ⬆️
.../src/content-single/HorizontalContentFeed/index.js 62.06% <20%> (-7.17%) ⬇️

@richarddubay richarddubay added merge When the tests pass, merge! and removed ready for review This is ready to be reviewd labels Oct 21, 2019
@richarddubay richarddubay merged commit 0562459 into develop Oct 21, 2019
@richarddubay richarddubay deleted the upgrade-1.2.0-beta.6 branch October 21, 2019 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge When the tests pass, merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants