This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
[DEV-4168] Fix Links #349
Merged
[DEV-4168] Fix Links #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redreceipt
reviewed
Oct 27, 2019
| @@ -88,7 +88,11 @@ class UserSettings extends PureComponent { | |||
| <TableView> | |||
| <Touchable | |||
| onPress={() => | |||
| openUrl('https://newspring.cc/privacy') | |||
There was a problem hiding this comment.
this means changing the WebBrowser did infact introduce breaking changes, that should be fixed in core too.
There was a problem hiding this comment.
Well, we just never changed these links to include the necessary arguments. What do we need to fix in core? Default to empty strings if the argument isn't there or something?
There was a problem hiding this comment.
Yes, it should be able to handle blank second and third arguments
redreceipt
approved these changes
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
What does this PR do, or why is it needed?
This PR fixes some of the
openUrllinks so that they have the correct arguments. This includes a fix to the link for the live banner.How do I test this PR?
Open the sim while things are live. Make sure that the live banner shows up, and that when you tap on it that Church Online opens up in an in-app browser.
TODO
REVIEW
Manual QA