Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

[DEV-4189] Release 1.2.0 #360

Merged
merged 6 commits into from
Nov 3, 2019
Merged

[DEV-4189] Release 1.2.0 #360

merged 6 commits into from
Nov 3, 2019

Conversation

richarddubay
Copy link
Member

DESCRIPTION

What does this PR do, or why is it needed?

How do I test this PR?

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@c79f0aa). Click here to learn what that means.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #360   +/-   ##
==========================================
  Coverage           ?   44.02%           
==========================================
  Files              ?      165           
  Lines              ?     1572           
  Branches           ?      170           
==========================================
  Hits               ?      692           
  Misses             ?      777           
  Partials           ?      103
Impacted Files Coverage Δ
...kages/newspringchurchapp/src/tabs/connect/index.js 66.66% <ø> (ø)
...pp/src/content-single/Features/ScriptureFeature.js 57.14% <ø> (ø)
...ntent-single/DevotionalContentItem/ScriptureTab.js 100% <ø> (ø)
packages/newspringchurchapp/src/scripture/index.js 100% <ø> (ø)
...ages/newspringchurchapp/src/tabs/discover/index.js 66.66% <ø> (ø)
...ringchurchapp/src/content-single/getContentItem.js 100% <ø> (ø)
...ngchurchapp/src/user-settings/Locations/MapView.js 68.18% <0%> (ø)
...es/newspringchurchapp/src/ui/WebBrowser/Browser.js 14.28% <0%> (ø)
...ages/newspringchurchapp/src/ui/SearchCard/index.js 100% <100%> (ø)

@richarddubay richarddubay added the ready for review This is ready to be reviewd label Nov 1, 2019
@redreceipt redreceipt merged commit d359371 into develop Nov 3, 2019
@redreceipt redreceipt deleted the release-1.2.0 branch November 3, 2019 00:29
@richarddubay richarddubay changed the title Release 1.2.0 [DEV-4189] Release 1.2.0 Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review This is ready to be reviewd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants