-
Notifications
You must be signed in to change notification settings - Fork 0
(DEV-4203) Fixes Prayer View on Small Phones #394
Conversation
@@ -16,10 +12,6 @@ import GET_CAMPUS_PRAYERS from '../data/queries/getCampusPrayers'; | |||
import GET_SAVED_PRAYERS from '../data/queries/getSavedPrayers'; | |||
import PrayerTab from './PrayerTab'; | |||
|
|||
const StyledHorizontalTileFeed = styled({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may cause problems but for the life of me I can't figure out why it was here...
Codecov Report
@@ Coverage Diff @@
## develop #394 +/- ##
=========================================
Coverage ? 45.2%
=========================================
Files ? 172
Lines ? 1670
Branches ? 183
=========================================
Hits ? 755
Misses ? 803
Partials ? 112
|
This is so much better. I don't mind the extra green space on the larger screens. Question: is it possible to scroll the whole thing and not just the bottom section? I expected the whole thing to move when I scrolled and not just the bottom part. Admittedly, it doesn't have to scroll far, so it's not a giant deal on the iPhone 6s. Also, I hope no one is trying to use our app on the iPhone SE (or 5s) but it does get a little wonky just scrolling the bottom half there: |
may want to break that out into another PR, that is more complicated because the background color of that section is white |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to come back to this at some point and see what we can do to make it better, but I think this solves the problem for now. Good work @redreceipt !
DESCRIPTION
What does this PR do, or why is it needed?
Simply wraps the bottom section of the prayer menu in a scroll view.
How do I test this PR?
Bring up the app on an iPhone 6s.
TODO
REVIEW
Manual QA