Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

cannot change the application --type using app:update #108

Closed
kapekost opened this issue Nov 16, 2016 · 5 comments
Closed

cannot change the application --type using app:update #108

kapekost opened this issue Nov 16, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@kapekost
Copy link

Steps to reproduce

  • Create an app no optional type specified (should default to 'voice')
  • Try to modify the type to 'rtc' by using the app:update

Expected behavior

The application should now have a type of 'rtc'

Actual behavior

The application type is still 'voice'

System configuration

Node version:
v5.12.0

NPM version:
3.8.6

Operating system:
Mac OS Sierra

@kapekost kapekost added the bug label Nov 16, 2016
@sammachin
Copy link
Contributor

Now that we have more than one possible type of application I think type should be a mandatory field without a default.

@cbetta cbetta self-assigned this Jan 24, 2017
@sammachin sammachin added this to the 0.3.3 milestone Mar 9, 2017
@cbetta
Copy link
Contributor

cbetta commented Mar 21, 2017

@sammachin @kapekost the problem for this actually lies in the Node library, and the docs:

https://github.com/Nexmo/nexmo-node/blob/bc368fc286e1b5a473f25728f6beb117615484be/src/index.js#L359

https://docs.nexmo.com/tools/application-api/api-reference#urparameters

Currently, both say that the only valid param is 'voice', and it's enforced in the SDK as such. I assume there are more, undocumented values? If so can I get a full list?

@cbetta cbetta modified the milestones: 0.3.3, 0.4.0 Mar 21, 2017
@kapekost
Copy link
Author

afaik only 'rtc' type is to be added, but also will require the callback urls to be optional

@cbetta
Copy link
Contributor

cbetta commented Mar 21, 2017

@kapekost hmmm, that makes things a bit messy.

Can you actually change an app from 1 type to the other? Is that a realistic thing?

@kapekost
Copy link
Author

@leggetter might have a better insight to this, or maybe just a respond saying that the type is not changed would be ok for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants