Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Add per project CLI configuration #113

Open
cbetta opened this issue Jan 24, 2017 · 3 comments
Open

Add per project CLI configuration #113

cbetta opened this issue Jan 24, 2017 · 3 comments
Assignees

Comments

@cbetta
Copy link
Contributor

cbetta commented Jan 24, 2017

This config could hold:

  • Preferred URL host
  • App key

Related issues:

Gut feeling says we can put this in the local .nexmorc we are already looking for

@cbetta cbetta self-assigned this Jan 24, 2017
@cbetta
Copy link
Contributor Author

cbetta commented Jan 31, 2017

Changes to be made:

@cbetta
Copy link
Contributor Author

cbetta commented Jan 31, 2017

Remaining questions:

  • Currently nexmo setup writes to a global file, and nexmo setup --local to a local file. This would be opposite to nexmo config:set as proposed.
  • What should be done if there's no global file but there is a local file and someone sets new config?

@leggetter
Copy link
Contributor

API key and secret are account level credentials where as application ID and public/private keys are Nexmo application level config entities. Page size is a CLI specific thing. This proposed solution is suggesting adding a way of overwriting account/global config at an application level and also allows some CLI config to be set in the same place 🤔

I'm a little concerned about merging account, CLI config, environment/API host config and application config. Should they be very clearly separated?

My feeling is that we keep #109 focused on application config and separate from this issue. I do think this issue can address account, CLI and environment config.

What should be done if there's no global file but there is a local file and someone sets new config?

Consistency suggests that config:set should default to global unless a --local flag is passed. Maybe the CLI could warn if config:set is called and there is local config?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants