Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: More commands as plugins on SD, refactor plugin wrapper #276

Merged
merged 25 commits into from
Nov 4, 2024
Merged

CLI: More commands as plugins on SD, refactor plugin wrapper #276

merged 25 commits into from
Nov 4, 2024

Conversation

Willy-JL
Copy link
Member

@Willy-JL Willy-JL commented Oct 24, 2024 •
edited
Loading

What's new

  • trying to free some flash space
  • moving more cli commands to plugins on sd card
  • cli command entry points are now more similar to OFW ones
  • to make CLI plugin wrappers just need CLI_PLUGIN_WRAPPER("name", callback) macro and "name_cli" entry in app manifest
  • removing unused icons from firmware blob
  • fix duplicate subghz region loading, oops

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL Willy-JL added the enhancement New enhancement or request label Oct 24, 2024
@Willy-JL Willy-JL self-assigned this Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Compiled f7 firmware for commit ccaf2ae4:

@Willy-JL Willy-JL added the bugfix Something isn't working label Nov 4, 2024
@Willy-JL Willy-JL changed the title Download More Flash! CLI: More commands as plugins on SD, refactor plugin wrapper Nov 4, 2024
@Willy-JL Willy-JL marked this pull request as ready for review November 4, 2024 06:38
@Willy-JL Willy-JL merged commit 2e7eedf into dev Nov 4, 2024
5 checks passed
@Willy-JL Willy-JL deleted the dl-more-flash branch November 4, 2024 08:42
@GameLord2011
Copy link
Contributor

Great, now I'll need to re-write my custom commands!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@Willy-JL Willy-JL

Labels
bugfix Something isn't working enhancement New enhancement or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Willy-JL @GameLord2011