Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe a small bug? #34

Closed
awesomedeer opened this issue Jul 2, 2020 · 1 comment
Closed

Maybe a small bug? #34

awesomedeer opened this issue Jul 2, 2020 · 1 comment

Comments

@awesomedeer
Copy link

awesomedeer commented Jul 2, 2020

Hi!
Thanks for maintaining NextPolish.
I think it's just a small issue below when I try to use NGS-data to polish:
Error message

Traceback (most recent call last):
  File "/public/home/wusong/sfw/NextPolish/nextPolish", line 460, in 
    main(args)
  File "/public/home/wusong/sfw/NextPolish/nextPolish", line 358, in main
    task = Task(set_task(cfg, 'map_genome', path = path, genomefile = genomefile, gtask = gtask), prefix = 'map_genome', convertpath = False)
  File "/public/home/wusong/sfw/NextPolish/nextPolish", line 33, in set_task
    cmd = map_genome(cfg, genomefile = args['genomefile'], task = args['gtask'])
  File "/public/home/wusong/sfw/NextPolish/nextPolish", line 144, in map_genome
    THREADS = str(cfg['align_threads']) if cfg['align_threads'] < 5 else '5'
TypeError: '<' not supported between instances of 'str' and 'int'

I am using NextPolish 1.2.4.
The code is modified to
THREADS = str(cfg['align_threads']) if int(cfg['align_threads']) < 5 else '5'
and it works.
Not so sure whether it's caused by the requirements or something else.

Best wishes
Song

@moold
Copy link
Member

moold commented Jul 3, 2020

Yes, it is a bug, and thank you for your report. I will fix it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants