Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overcoming the Need for TSConfig Multiple Inheritance #195

Closed
johncmunson opened this issue Jan 22, 2022 · 4 comments
Closed

Overcoming the Need for TSConfig Multiple Inheritance #195

johncmunson opened this issue Jan 22, 2022 · 4 comments

Comments

@johncmunson
Copy link

I wrote up a lengthy discussion of this over on the Typescript github issue for multiple inheritance, but I referenced this project because this is where I first encountered it.

@NiGhTTraX I'm curious if this is something that you have investigated before? With TS not directly supporting multiple inheritance in the tsconfig files, have you come up with any alternative solutions? Or, has this just not been a real issue for you yet?

@NiGhTTraX
Copy link
Owner

Hey @johncmunson, good question! This project actually contains an example of what you're describing — the components package has to set jsx: true in both the IDE config and the build config. The other packages don't need it, so that's why it's not hoisted in the root config. It would definitely be nice to have multiple inheritance, so I could set that in a single config and then inherit it, along with the monorepo config that holds the path aliases.

At the end of the day, tsconfigs don't change that often, so a bit of duplication doesn't hurt IMO. Multiple inheritance would be an elegant solution, so let's hope the TS team will implement it at some point, seeing as monorepos are becoming more common.

@johncmunson
Copy link
Author

Oh cool, thanks for pointing that out! I basically arrived at the same solution as you did as I was pondering this earlier today. However, instead of having my IDE configs at the workspace level extend from the root level IDE config, I decided to have them extend from the sibling build config, and then I duplicated the path aliases everywhere.

Either way involves a bit of duplication, but you're right, it's not really a big deal since the files rarely change.

In addition to multiple inheritance, I've also seen people request support for tsconfig.js or tsconfig.ts files, which would also help out in this scenario.

@johncmunson
Copy link
Author

@NiGhTTraX
Copy link
Owner

Thanks for the reminder @johncmunson! Before I use the new multiple inheritance feature to remove some duplication in the tsconfigs, I will:

  1. Let the tooling ecosystem adapt to the new version. chore(deps): update dependency typescript to v5 #308 shows some dependencies that need to accept 5.0 in their peer dependencies.
  2. Give everyone some time to hop onto the new version. People might clone this repo and then downgrade the TS version to match what they're using in their project only to find out that it breaks everything because of the multiple inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants