-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedora rpm build | two tests are failing #252
Comments
These tests are disabled in the Fedora build, but I can enable them and provide detailed info and the traceback. Fedora 33 (rawhide) is currently on Python3.9. The versions of all the python packages that are involved can be see in the log file here: For example:
|
Here's the complete trace:
Complete logs are attached: |
Have a good day, from what I could perceive, there would be an evaluation error at NiaPy/NiaPy/tests/test_benchmark_functions.py Line 438 in d165b24
because of the division in the sin function at NiaPy/NiaPy/benchmarks/infinity.py Line 84 in d165b24
The question is, why should we need to start with a zero-filled initialization at this benchmark? It would be recommended to do so with a 1e-6 value. Would not it? |
Maybe a self.algo.setParameters() call could fix some errors as well if inserted after Line 82 in d165b24
This would be tested. |
Sorry, it seems that the error is at the proportional function call, where avg goes to infty and later, x_f goes to infinity as well. |
This was fixed at #266 , please review it carefully to see if it is correct. |
Code styling reviewed and added a new pull request #267 |
Thank you @sisco0! Issue solved by merging PR #267. @all-contributors add @sisco0 for code contribution |
I've put up a pull request to add @sisco0! 🎉 |
Two tests are failing:
More info:
https://src.fedoraproject.org/rpms/python-niapy/blob/master/f/python-niapy.spec#_86
The text was updated successfully, but these errors were encountered: