Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix scrutinizer #322

Closed
wants to merge 11 commits into from
Closed

Conversation

GregaVrbancic
Copy link
Contributor

Summary

For some time now, the scrutinizer is failing to conduct code analysis since it fails running "python setup.py install".

More info about error: https://scrutinizer-ci.com/g/NiaOrg/NiaPy/inspections/f1bbc729-032b-453a-bb7f-1b855fad1531

In this PR the python version is updated to 3.9.5

Any additional suggestions are more than welcome.

For some time now, the scrutinizer is failing to conduct code analysis since it fails running "python setup.py install". 

More info about error: https://scrutinizer-ci.com/g/NiaOrg/NiaPy/inspections/f1bbc729-032b-453a-bb7f-1b855fad1531

In this PR the python version is updated to 3.9.5
@GregaVrbancic
Copy link
Contributor Author

@zStupan maybe you have some idea, why other tests are failing since there are no other changes than in scrutinizer.yml file?

@zStupan
Copy link
Contributor

zStupan commented May 29, 2021

There was a linter error in #316. Specifically in setup.py MINIMUM_PYTHON_VERSION = (3,6) should be MINIMUM_PYTHON_VERSION = (3, 6), with a space after the comma. I fixed this in my PR.

@GregaVrbancic
Copy link
Contributor Author

Oh, I see. Thanks for the quick reply 😃

@GregaVrbancic
Copy link
Contributor Author

Closing this PR, since the fixes were applied in #321

@GregaVrbancic GregaVrbancic deleted the Attempt-to-fix-scrutinizer branch May 31, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants