-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always send output to flake callback #98
Conversation
This change ensures that the protractor flake callback will always receive the output log even if the first test pass succeeds with no failures.
Apologies for the very delayed response. I think this sounds fine. I'm curious what is your use case? Also, if possible could you include a unit test for this? Thanks! |
Hi there, Our use case is that we want to send the log in an email at the end of the test pass. Currently the log will only be passed to the callback function if there was an error with any of the specs, we want the log regardless. I'll add a unit test when I am back at work tomorrow. Thanks. |
Great thanks for that detail makes sense! |
Hi again Nick, I have added a unit test as requested. |
I'll troubleshoot that failure (looks like a typing issue for node 6.x) and merge this in tomorrow. |
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This appears to have caused #102 |
…duce feature after more diagnosis
Restore typescript and features in #98
This change ensures that the protractor flake callback will always receive the output log even if the first test pass succeeds with no failures.