Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Types overload missing for Push.Permission.request() #243

Open
Jicmou opened this issue Feb 19, 2020 · 0 comments
Open

Types overload missing for Push.Permission.request() #243

Jicmou opened this issue Feb 19, 2020 · 0 comments
Labels
enhancement

Comments

@Jicmou
Copy link

Jicmou commented Feb 19, 2020

Push.Permission.request()can either be called with 2 callback functions as parameters, or with no parameter at all, and in that cases, returns a Promise.

index.d.ts should be updated to take the two call signatures into account.

I can make a PR to fix that.

Regards,
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type overload for Push.Permission.request()
2 participants
@theLufenk @Jicmou