BUG: Coerce GenericSeq path attributes to str #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `coerce=True` to the `annot_path` and `notated_path` attributes of the GenericSeq pandera schema, to force them to be converted to strings. This fixes failures on CI where I guess these get passed in as Path classes even though when I run tests locally they are not and tests pass? Seems like a good idea to force them to be string anyway.
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 41 41
Lines 1510 1510
=======================================
Hits 1421 1421
Misses 89 89 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
NickleDave
force-pushed
the
fix-generic-seq-pandera-error
branch
from
c1ef7a5 to
d9a75b6
Compare
NickleDave
added a commit
that referenced
this pull request
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this will fix CI failures.
We coerce the
annot_pathandnotated_pathattributes of the pandera GenericSeq schema to be strings -- apparently they get passed in as pathlib.Path on CI somehow? I can't reproduce the error locally. But coercing them to string seems to fix it. And it makes sense in general to force these attributes to be strings since there's nopathlibdtype for pandas DataFrames (without using a library like pandas-pathlib)