Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/crc configurations #157

Merged
merged 5 commits into from
Apr 19, 2024
Merged

refactor/crc configurations #157

merged 5 commits into from
Apr 19, 2024

Conversation

Nicoretti
Copy link
Owner

@Nicoretti Nicoretti commented Apr 14, 2024

Fixes #148 #145

  • Change output format of rev input and output
  • Rename Crc16.CCITT to Crc16.XMODEM
  • Add KERMIT to Crc16 configurations
  • Update crc configuration(s) overview
  • Update changelog

@Nicoretti Nicoretti self-assigned this Apr 14, 2024
@Nicoretti
Copy link
Owner Author

Hi @IsaacDynamo and @cmcqueen,

you may want to have a look at this, once merged I will publish this as part of the 7.0.0 release.

best
Nico

@Nicoretti Nicoretti linked an issue Apr 14, 2024 that may be closed by this pull request
Copy link

@IsaacDynamo IsaacDynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@cmcqueen
Copy link

Looks good, thanks!

@Nicoretti Nicoretti merged commit bf8fa45 into master Apr 19, 2024
24 checks passed
@Nicoretti Nicoretti deleted the refactor/crc-configurations branch April 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 Refactor CRC-16 Configuration Naming and Expand Variants 🐞Predefined Crc16.CCITT is confusing
3 participants