Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural Equality: Treat ImmutableArray<T> the same as Array #42

Open
NightOwl888 opened this issue Nov 2, 2021 · 0 comments
Open
Labels
is:bug Something isn't working is:enhancement New feature or request is:feature pri:normal up for grabs This issue is open to be worked on by anyone

Comments

@NightOwl888
Copy link
Owner

NightOwl888 commented Nov 2, 2021

Since ImmutableArray<T> is yet another array implementation of IStructuralEquatable that could be compared against Array, it must be treated like an Array, not compared using IStructuralEquatable.

There are several places in the codebase where we do this:

Unfortunately, we have some challenges to deal with, since if we don't know the generic closing type of ImmutableArray<T>, we will need to do some work to materialize it before we can compare it.

@NightOwl888 NightOwl888 added is:bug Something isn't working is:enhancement New feature or request is:feature pri:normal up for grabs This issue is open to be worked on by anyone labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working is:enhancement New feature or request is:feature pri:normal up for grabs This issue is open to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

1 participant