Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: J2N.Character.CodePointAt(char[], int, int): Convert limit parameter to length (a .NET convention) #64

Open
NightOwl888 opened this issue Dec 26, 2023 · 0 comments
Labels
Milestone

Comments

@NightOwl888
Copy link
Owner

This is a breaking API change that will require a major version bump.

Current API:

namespace J2N
{
    public static class Character
    {
        public static int CodePointAt(this char[] seq, int index, int limit)
    }
}

Desired API:

namespace J2N
{
    public static class Character
    {
        public static int CodePointAt(this char[] seq, int index, int length)
    }
}

Of course, the business logic needs to change to accommodate this fix.

@NightOwl888 NightOwl888 added this to the 3.0 milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant