-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch draw calls? #159
Comments
Performance seems like an issue for this crate currently, I'm drawing the same thing multiple times and notice a big dip in fps, batching should help a lot |
With Bevy 0.12 getting automatic batching, it might be possible to rework We would need to find some way to reuse generated mesh assets so that shape entities with the same attributes would point at the same mesh asset. I'm guessing that this is more complicated than it sounds -- we need to make sure Bevy's asset lifecycle continues to work. i.e. assets that are no longer referenced in the world get dropped. |
Is this fixed? Since Bevy should now group material and meshes together? |
As far as I know, no. Last time I looked, Bevy only batches when the mesh handle is identical and unless I missed something, that hasn't changed. My previous message should still generally be true |
That actually makes sense. It should be like that. So if the handle is the same for the mesh and material, it will batch? That’s perfect. |
See bevyengine/bevy#3763 (comment). I'm not sure if this is actually an issue.
The text was updated successfully, but these errors were encountered: