-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add PEP 604 style type hint support #218
Merged
NilsJPWerner
merged 10 commits into
NilsJPWerner:master
from
s-weigand:PEP-604-typehint-support
Feb 8, 2022
Merged
✨ Add PEP 604 style type hint support #218
NilsJPWerner
merged 10 commits into
NilsJPWerner:master
from
s-weigand:PEP-604-typehint-support
Feb 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilsJPWerner
reviewed
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! The code looks good except for two test suggestions.
s-weigand
force-pushed
the
PEP-604-typehint-support
branch
from
February 8, 2022 08:17
67f2c2c
to
584b585
Compare
shaperilio
pushed a commit
to shaperilio/autoDocstring
that referenced
this pull request
Feb 11, 2022
NilsJPWerner
added a commit
that referenced
this pull request
Feb 16, 2022
* master: (29 commits) Merge publish and test workflows Handle nested square brackets in type hints (#185) Improve changelog format and add publish release action Only run publish workflow after successful test workflow Bump version to 0.6.1 Remove one-line-sphinx-notypes and update changelog Add example documentation of docstring formats (#224) Rename oneline-rst to one-line-sphinx Bump version to 0.6.0 Fixes #212: Parse Literal type hints in function definition (#223) Add debug log statements Update all dependencies (#222) Add more notypes docstring templates (#221) Fixes #94: Switch square brackets in placeholder to underscores (#220) Avoid extra newlines in templates (#203) Add oneline-rst docstring to menu and readme so its accessible (#195) Add PEP 604 style type hint support (#218) Fix yield underline in numpy template (#216) Update READEME Switch to github actions (#214) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PEP 604 style type hints are not supported, because everything after the pipe character (
|
) gets removed.E.g. this function
would generate the following docstring
So one has to manually check and add them back.