Support loading workflow definitions from database #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmokki
force-pushed
the
on-demand-definiton-loading
branch
from
28fc406
to
ffbe63b
Compare
efonsell
reviewed
Jun 6, 2022
nflow-engine/src/main/java/io/nflow/engine/service/WorkflowDefinitionService.java
Outdated
Show resolved
Hide resolved
efonsell
reviewed
Jun 6, 2022
nflow-engine/src/main/java/io/nflow/engine/service/WorkflowDefinitionService.java
Outdated
Show resolved
Hide resolved
gmokki
force-pushed
the
on-demand-definiton-loading
branch
from
d99b6b7
to
7d9a191
Compare
efonsell
reviewed
Jun 7, 2022
nflow-engine/src/main/java/io/nflow/engine/service/WorkflowDefinitionService.java
Outdated
Show resolved
Hide resolved
|
konffin default arvo pitäis olla default propsuissa ja sitten se voisikin olla required |
efonsell
requested changes
Jun 7, 2022
nflow-engine/src/test/java/io/nflow/engine/service/WorkflowDefinitionServiceTest.java
Outdated
Show resolved
Hide resolved
gmokki
force-pushed
the
on-demand-definiton-loading
branch
6 times, most recently
from
9d1d14a
to
4bdfde2
Compare
gmokki
changed the title
…n.load=true is set
Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
…ify instead to keep spotbugs happy
…ing the signature of existing
…ride the db profile
…ses can insert/query them while another server with code runs them
gmokki
force-pushed
the
on-demand-definiton-loading
branch
from
b5918e6
to
01fb149
Compare
… stored workflow definition loaded from other executors
eputtone
requested changes
Jul 29, 2022
There was a problem hiding this comment.
Looks otherwise good, the comments require no action, but the implementation seems to miss handling for this kind of scenarios:
- Two executors 1 & 2 in the same group, both have dispatcher running.
- Executor 1 has implementation for WorkflowDefinition1
- Executor 2 has implementation for WorkflowDefinition2
- WorkflowDefinition1 instance is submitted - prevent it from being executed on executor 2
CHANGELOG.md
Outdated
| @@ -14,6 +15,13 @@ | |||
| **Details** | |||
|
|
|||
| - `nflow-engine` | |||
| - Add support to manage (create, update and read, but not execute) workflow instances without having the workflow implementation classes in the classpath. | |||
| - If a workflow definition is not found from the classpath, it is loaded from the database and stored in memory. | |||
| - Workflow definitions that are loaded from the database are refreshed at most at configured interval (`nflow.definition.loadMissingFromDatabaseSeconds`, default 60). | |||
There was a problem hiding this comment.
Theoretically, someone might depend on the fact that instances cannot be managed for historical workflow definitions. So need to consider which kind of version needs to be released next, or could start with -1 as default and change the default to 60 in next major version?
There was a problem hiding this comment.
I find that a bit too theoretical to worry about breaking it. Nevertheless, I added few lines on readme about that and instructions on how to disable the new functionality.
|
|
||
| private static WorkflowState getInitialState(StoredWorkflowDefinition stored) { | ||
| return stored.states.stream() | ||
| .filter(state -> start.name().equals((state.type))) |
There was a problem hiding this comment.
It a shame that we don't currently persist the default start state (=initial state). But can't be helped here, perhaps add another issue about that.
nflow-engine/src/main/java/io/nflow/engine/service/WorkflowDefinitionService.java
Outdated
Show resolved
Hide resolved
eputtone
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum rate can be controller with
nflow.definition.loadMissingFromDatabaseSeconds- default rate is once every 60 seconds. But the definitions are only loaded from database if needed, not constantly in the background.