Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installables with empty outputsToInstall are installed, and do not use default output #10830

Open
roberth opened this issue Jun 3, 2024 · 2 comments
Labels
bug idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. new-cli Relating to the "nix" command

Comments

@roberth
Copy link
Member

roberth commented Jun 3, 2024

I've tracked the cause down to 1ddabe1, which just adds the out behavior without any explanation.

It see multiple issues with it:

Originally posted by @roberth in #10825 (comment)

@roberth roberth added bug new-cli Relating to the "nix" command labels Jun 3, 2024
@fricklerhandwerk fricklerhandwerk added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Jun 12, 2024
@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Jun 12, 2024

Triaged in Nix team meeting:

  • @tomberek: not sure if it makes sense to give the empty list an additional meaning, that would be adding a new convention
  • @fricklerhandwerk: find it questionable if we should even spend time on this, since that would be a Nixpkgs convention we'd be enforcing "from below" (we already have enough coupling)
  • @roberth: just proposing to make it more regular; if it's specifically set to the empty list, we should not install anything
    • @edolstra: agreed, possibly could throw a warning
      • @fricklerhandwerk: throwing a warning for users of nix profile may not help if they are consumers of Nixpkgs, which they either won't (be able to) change on the fly anyway, or we'd have to tell them how to do it (I don't want Nix to be aware of Nixpkgs)
  • @edolstra: if we want to change the behavior, we should be quick about it, since now people will start depending on that code path not crashing
  • @roberth: by the way, nix build also observes this attribute
  • decision: change it as proposed

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-06-12-nix-team-meeting-minutes-152/46958/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. new-cli Relating to the "nix" command
Projects
None yet
Development

No branches or pull requests

3 participants