Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for builtins.fetchurl is incomplete #1489

Open
lukego opened this issue Jul 25, 2017 · 8 comments
Open

Documentation for builtins.fetchurl is incomplete #1489

lukego opened this issue Jul 25, 2017 · 8 comments
Assignees

Comments

@lukego
Copy link

lukego commented Jul 25, 2017

The reference documentation (Built-in Functions) only describes builtins.fetchurl <url> but it is possible/common to supply an attribute set that includes a sha256 hash and so on instead of a raw URL.

@bobvanderlinden
Copy link
Member

I see what you mean, it should also allow sha256 to be defined inside a attributeset (https://github.com/NixOS/nix/blob/master/corepkgs/fetchurl.nix). However, when I try to use builtins.fetchurl it seems to not accept any of those attributes. I'm not sure what's up, but I really want to use builtins.fetchurl like pkgs.lib.fetchurl, just so that I can use the netrc-file setting from nix.conf. Not allowing a SHA to be defined will result in a potentially non-reproducible build.

@stale
Copy link

stale bot commented Feb 15, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Feb 15, 2021
@NorfairKing
Copy link

NorfairKing commented Feb 17, 2021

Just bumped into this problem again, still relevant.

EDIT: because this documentation wasn't there, I was looking at https://github.com/NixOS/nix/blob/75efa421340b8fb2be6cf5351d3ef36a93b294e1/src/libexpr/fetchurl.nix to solve a non-happy-path problem.

@stale stale bot removed the stale label Feb 17, 2021
@stale
Copy link

stale bot commented Aug 17, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Aug 17, 2021
@NorfairKing
Copy link

Still not stale.

@stale stale bot removed the stale label Aug 17, 2021
@stale
Copy link

stale bot commented Apr 17, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Apr 17, 2022
@NorfairKing
Copy link

I marked this as not stale due to activity from the stale bot.

@stale stale bot removed the stale label Apr 17, 2022
@stale stale bot added the stale label Oct 30, 2022
@tkerber
Copy link
Member

tkerber commented Dec 7, 2023

Still relevant.

@stale stale bot removed the stale label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants