The pre-build-hook isn't called if the sandbox is disabled

[thufschmitt]

If sandbox is set to false, then any pre-build-hook option is silently ignored.

That kinda makes sense since the only think that hook can do is add paths to the sandbox, but in that case the pre-build-hook name is misleading. That's also not what the documentation states.

[stale]

I marked this as stale due to inactivity. → More info

[stale]

I closed this issue due to inactivity. → More info

[me-and]

The current behaviour seems to have changed since this was raised. On my system, a command like nix-build --option pre-build-hook /path/to/executable will fail with the message error: program '/path/to/executable' failed with exit code 127 if I don't also pass --option sandbox false.

I'd intended to use the pre-build hook as a mechanism for checking whether a given derivation was one of a list of known bad derivations, so the build could fail straight away rather than only after getting to the part of the build process that's broken. While that's not pure, I don't think it requires breaking the sandboxing model for the build itself.