Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ValidPathInfo::narHash mandatory #3845

Closed
Ericson2314 opened this issue Jul 21, 2020 · 1 comment
Closed

Make ValidPathInfo::narHash mandatory #3845

Ericson2314 opened this issue Jul 21, 2020 · 1 comment
Labels
bug

Comments

@Ericson2314
Copy link
Member

Ericson2314 commented Jul 21, 2020 •
edited
Loading

Right now it is basically deemed mandatory, but this isn't enforced by the types. After #3738 it will become std::optional<Hash> to reflect how the code exists today. This issue is to make it Hash, and always initialized by construction, again.

(This can be assigned to me.)
@Ericson2314 Ericson2314 mentioned this issue Jul 30, 2020
Merged
@Ericson2314
Copy link
Member Author

Fixed in #3899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ericson2314