Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise nix store ping #8914

Closed
fricklerhandwerk opened this issue Sep 4, 2023 · 6 comments
Closed

Stabilise nix store ping #8914

fricklerhandwerk opened this issue Sep 4, 2023 · 6 comments
Assignees
Labels
idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. new-cli Relating to the "nix" command RFC Related to an accepted RFC

Comments

@fricklerhandwerk
Copy link
Contributor

This implements NixOS/rfcs#136. This issue is agreed-upon by the https://github.com/orgs/NixOS/teams/nix-team

Required changes:

  • rename to nix store info
  • return bool or null for the trusted field instead of currently int
    • if the underlying enum is converted to an enum struct, the potential to make this mistake will dissapear
  • ensure that --json output fits the JSON guidelines
@fricklerhandwerk fricklerhandwerk added new-cli Relating to the "nix" command idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. RFC Related to an accepted RFC labels Sep 4, 2023
@thufschmitt thufschmitt added this to the CLI Stabilisation milestone Sep 4, 2023
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-09-04-nix-team-meeting-minutes-85/32608/1

@vicky1999
Copy link
Contributor

Hello, I would like to work on this task. Can I start working on this?

@Ericson2314
Copy link
Member

Yes you can!

@vicky1999
Copy link
Contributor

vicky1999 commented Sep 13, 2023

@fricklerhandwerk
I have a doubt in point 2 (return bool or null for the trusted field instead of currently int):
Based on the comment, I have made the changes to display the true/false value for trusted value in store info and info json. Kindly let me know if this is the expectation.

image

@vicky1999
Copy link
Contributor

@fricklerhandwerk The json payload, I saw that the json argument is not formatted. This will be fine. But, I think it will look more nicer if the json is formatted. So, I have made some changes to display the formatted json instead of single line json.

image

Kindly let me know if I can push this change to the current open PR (#8975 ).

@fricklerhandwerk
Copy link
Contributor Author

I think it's good to have. Let's continue the conversation in the PR though. We'll assign one maintainer for review to keep everyone else's noise level low.

@thufschmitt thufschmitt moved this to To triage in Nix team Dec 22, 2023
@thufschmitt thufschmitt moved this from To triage to Done in Nix team Jan 12, 2024
@thufschmitt thufschmitt moved this from Done to 🏁 Review in Nix team Feb 28, 2024
@thufschmitt thufschmitt moved this from 🏁 Review to Done in Nix team Feb 28, 2024
@thufschmitt thufschmitt moved this from Accepted work to Done in Nix implementation board Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. new-cli Relating to the "nix" command RFC Related to an accepted RFC
Projects
Status: Done
Status: Done
Development

No branches or pull requests

5 participants