Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle experimental feature dependencies correctly, completely, DRY #9532

Open
roberth opened this issue Dec 4, 2023 · 1 comment
Open

Comments

@roberth
Copy link
Member

roberth commented Dec 4, 2023

Describe the bug

While working on the fetchTree docs, #9258 we found two issues:

  • The flakes feature did not automatically enable fetch-tree
  • The fetchTree documentation only mentions fetch-tree instead of: fetch-tree or flakes.

We might violate DRY a bit in #9258 to get the docs to render first. This issue describes the tech debt.

Note that we don't have to do elaborate graph concepts in code; just an interface that gets the correct info for these two use cases, and an implementation that gets the job done with minimal complexity.

Expected behavior

Completeness, soundness, DRY.

nix-env --version output

Additional context

Priorities

Add 👍 to issues you find important.

@Ericson2314
Copy link
Member

Ericson2314 commented Dec 4, 2023

The flakes feature did not automatically enable fetch-tree

I am confused. I made hack with a fixme on master in src/libutil/config.cc in f0adb72, then 12953b9 removes the FIXME but leaves the hack

We should definitely make a better non-hacking version of this: declarative experimental feature implications, I think. But we shouldn't need another hack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants