Gate experimental features in DerivationOutput::fromJSON
#8231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
add-derivation-xp-gates
branch
from
1585ad2 to
3109914
Compare
roberth
reviewed
Apr 17, 2023
Ericson2314
force-pushed
the
add-derivation-xp-gates
branch
from
3109914 to
9aa9818
Compare
This is an entry point for outside data, so we need to check enabled experimental features here.
Ericson2314
force-pushed
the
add-derivation-xp-gates
branch
from
9aa9818 to
aa74c7b
Compare
8 tasks
roberth
approved these changes
Apr 18, 2023
roberth
reviewed
Apr 18, 2023
| @@ -136,11 +136,15 @@ struct DerivationOutput : _DerivationOutputRaw | |||
| const Store & store, | |||
| std::string_view drvName, | |||
| std::string_view outputName) const; | |||
| /** | |||
| * @param xpSettings Stop-gap to avoid globals during unit tests. | |||
There was a problem hiding this comment.
Testability is important enough to warrant a parameter like this, but it is transitively a stop-gap, because experimental features are a stop-gap.
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an entry point for outside data, so we need to check enabled experimental features here.
Context
I should have done this when
nix derivation addwas added in #7887, but I forgot. Sorry!Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.