From e90f650d179af4449d744c35e868cb3c3ea9782a Mon Sep 17 00:00:00 2001
From: Anderson Torres <torres.anderson.85@protonmail.com>
Date: Sat, 4 May 2024 10:24:17 -0300
Subject: [PATCH] duckstation: migrate to by-name

---
 .../duckstation/001-fix-test-inclusion.diff   |  0
 .../du}/duckstation/002-hardcode-vars.diff    |  0
 .../du/duckstation/package.nix}               | 68 +++++++++++--------
 pkgs/top-level/all-packages.nix               |  2 -
 4 files changed, 39 insertions(+), 31 deletions(-)
 rename pkgs/{applications/emulators => by-name/du}/duckstation/001-fix-test-inclusion.diff (100%)
 rename pkgs/{applications/emulators => by-name/du}/duckstation/002-hardcode-vars.diff (100%)
 rename pkgs/{applications/emulators/duckstation/default.nix => by-name/du/duckstation/package.nix} (83%)

diff --git a/pkgs/applications/emulators/duckstation/001-fix-test-inclusion.diff b/pkgs/by-name/du/duckstation/001-fix-test-inclusion.diff
similarity index 100%
rename from pkgs/applications/emulators/duckstation/001-fix-test-inclusion.diff
rename to pkgs/by-name/du/duckstation/001-fix-test-inclusion.diff
diff --git a/pkgs/applications/emulators/duckstation/002-hardcode-vars.diff b/pkgs/by-name/du/duckstation/002-hardcode-vars.diff
similarity index 100%
rename from pkgs/applications/emulators/duckstation/002-hardcode-vars.diff
rename to pkgs/by-name/du/duckstation/002-hardcode-vars.diff
diff --git a/pkgs/applications/emulators/duckstation/default.nix b/pkgs/by-name/du/duckstation/package.nix
similarity index 83%
rename from pkgs/applications/emulators/duckstation/default.nix
rename to pkgs/by-name/du/duckstation/package.nix
index 91d2b23705ad734..be18010e62d239c 100644
--- a/pkgs/applications/emulators/duckstation/default.nix
+++ b/pkgs/by-name/du/duckstation/package.nix
@@ -1,26 +1,32 @@
-{ lib
-, stdenv
-, fetchFromGitHub
-, SDL2
-, cmake
-, cubeb
-, curl
-, extra-cmake-modules
-, libXrandr
-, libbacktrace
-, makeWrapper
-, ninja
-, pkg-config
-, qtbase
-, qtsvg
-, qttools
-, qtwayland
-, substituteAll
-, vulkan-loader
-, wayland
-, wrapQtAppsHook
+{
+  lib,
+  SDL2,
+  cmake,
+  cubeb,
+  curl,
+  extra-cmake-modules,
+  fetchFromGitHub,
+  libXrandr,
+  libbacktrace,
+  makeWrapper,
+  ninja,
+  pkg-config,
+  qt6,
+  stdenv,
+  substituteAll,
+  vulkan-loader,
+  wayland,
 }:
 
+let
+  inherit (qt6)
+    qtbase
+    qtsvg
+    qttools
+    qtwayland
+    wrapQtAppsHook
+  ;
+in
 stdenv.mkDerivation (finalAttrs: {
   pname = "duckstation";
   version = "0.1-6292";
@@ -46,8 +52,8 @@ stdenv.mkDerivation (finalAttrs: {
   ];
 
   nativeBuildInputs = [
+    SDL2
     cmake
-    extra-cmake-modules
     ninja
     pkg-config
     qttools
@@ -57,6 +63,7 @@ stdenv.mkDerivation (finalAttrs: {
   buildInputs = [
     SDL2
     curl
+    extra-cmake-modules
     libXrandr
     libbacktrace
     qtbase
@@ -66,17 +73,20 @@ stdenv.mkDerivation (finalAttrs: {
   ]
   ++ cubeb.passthru.backendLibs;
 
-  strictDeps = true;
-
   cmakeFlags = [
     (lib.cmakeBool "BUILD_TESTS" true)
   ];
 
-  doCheck = true;
-  checkPhase = ''
-    runHook preCheck
-    bin/common-tests
-    runHook postCheck
+  strictDeps = true;
+
+  doInstallCheck = true;
+
+  installCheckPhase = ''
+    runHook preInstallCheck
+
+    $out/share/duckstation/common-tests
+
+    runHook postInstallCheck
   '';
 
   installPhase = ''
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 95ed28ca8ba6e12..2e05dd4d9448ff2 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -2646,8 +2646,6 @@ with pkgs;
     inherit (darwin.apple_sdk_11_0.frameworks) AudioUnit Carbon Cocoa;
   };
 
-  duckstation = qt6Packages.callPackage ../applications/emulators/duckstation { };
-
   dynamips = callPackage ../applications/emulators/dynamips { };
 
   emu2 = callPackage ../applications/emulators/emu2 { };