Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run passthru.tests on hydra #136026

Open
roberth opened this issue Aug 28, 2021 · 1 comment
Open

Run passthru.tests on hydra #136026

roberth opened this issue Aug 28, 2021 · 1 comment
Labels
0.kind: enhancement Add something new 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: testing Tooling for automated testing of packages and modules

Comments

@roberth
Copy link
Member

roberth commented Aug 28, 2021

Run passthru.tests on hydra, so we can spot failures there and make the fetchgit tests a channel blocker.

This adds approximately 400 derivations for x86_64-linux and presumably slightly smaller amounts for other systems. The tests are usually sanity checks written by us, so they are generally quick. Their outputs are virtually empty.

This could work like packageTests in #136022 but with special handling of

  • license, to avoid uploading illegal deps
  • hydraPlatforms, to avoid attempts to build on unsupported systems
  • more?

Possible solutions:
a. copy the relevant meta stuff while constructing pkgs.packageTests. Add recurseIntoAttrs.
b. use the same traversal but apply it to all of release.nix instead of using recurseIntoAttrs.

The latter seems more elegant, as it reuses existing hydra-adjacent logic.

Notify maintainers

@edolstra @grahamc

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: packageTests
# a list of nixos modules affected by the problem
module:
@roberth roberth added 0.kind: bug Something is broken 0.kind: enhancement Add something new 6.topic: testing Tooling for automated testing of packages and modules and removed 0.kind: bug Something is broken labels Aug 28, 2021
@stale
Copy link

stale bot commented Apr 28, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: testing Tooling for automated testing of packages and modules
Projects
None yet
Development

No branches or pull requests

1 participant