Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk 17 #137956

Closed
asbachb opened this issue Sep 15, 2021 · 10 comments
Closed

openjdk 17 #137956

asbachb opened this issue Sep 15, 2021 · 10 comments
Labels
0.kind: packaging request Request for a new package to be added 6.topic: java Including JDK, tooling, other languages, other VMs

Comments

@asbachb
Copy link
Contributor

asbachb commented Sep 15, 2021

Project description
Next LTS release of openjdk / java.

(I think it would be nice to have a new package alias jdk-lts.)

Metadata

@asbachb asbachb added the 0.kind: packaging request Request for a new package to be added label Sep 15, 2021
@asbachb
Copy link
Contributor Author

asbachb commented Sep 15, 2021

I've some work in progress of packaging jtreg in order to test the jdk build: https://github.com/asbachb/nixpkgs/tree/jtreg

@asbachb asbachb added the 6.topic: java Including JDK, tooling, other languages, other VMs label Sep 15, 2021
@tadfisher
Copy link
Contributor

Aliases aren't great, as updating nixpkgs would mean (in this case) going from JDK 11 to JDK 17, which is likely to break something. We already have openjdk${version} attrs which can be used to "pin" to a specific JDK release.

@asbachb
Copy link
Contributor Author

asbachb commented Sep 16, 2021

We already had some discussion about that: https://discourse.nixos.org/t/retirement-of-old-openjdk-releases/9929

I still think that the best approach would be that the default jdk should point to the lts release or have a dedicated alias for that.

@Uthar
Copy link
Contributor

Uthar commented Sep 26, 2021

To start off, this builds and works fine Uthar@f9bd12e, some notes:

  • Can't run tests because jtreg isn't packaged (https://github.com/asbachb/nixpkgs/tree/jtreg
  • Can't build docs because it fails with error: unknown tag: textarea
  • Haven't built the case with no adoptopenjdk as bootstrap, but the derivation itself compiles just fine with the if removed.
  • Worked around bizarre error in LegalNoticeFilePlugin by patching out the failing check

@asbachb
Copy link
Contributor Author

asbachb commented Sep 26, 2021

Just fyi: I did not package jtrg yet as I'm currently unable to validate any jdk build due to any errors. I think in this state it won't provide any benefit.

@Uthar
Copy link
Contributor

Uthar commented Oct 2, 2021

Hmm... I'm not sure if older jdks in nixpkgs run tests either. E.g. this openjdk16 build looks like it builds the tests but doesn't run them - there's no "X tests passed" or anything like that in the logs.

Same for javadoc - older jdks dont include them as well - they build them but don't copy to $out

@asbachb
Copy link
Contributor Author

asbachb commented Oct 2, 2021

Normally other distros package javadoc separately. Yeah currently there are no tests. That was the reason I tried to package jtreg.

@Uthar
Copy link
Contributor

Uthar commented Oct 2, 2021

Also, thedocs target fails only during building javadoc for JavaFX, I tried also with JavaFX 17.0.0.1, but no change. Weird. (Works with enableJavaFx = false)

Also, to build JavaFX 17 i had to set COMPILE_WEBKIT=false in gradle, if someone ever has this problem

I guess this isnt so important now and just building the images target is good enough, so I started the PR

@tadfisher
Copy link
Contributor

This can be closed, correct?

@KamilaBorowska
Copy link
Member

Closed by #140257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added 6.topic: java Including JDK, tooling, other languages, other VMs
Projects
None yet
Development

No branches or pull requests

4 participants