Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome extension brightness-control-using-ddcutil not patched #146926

Closed
pp5x opened this issue Nov 21, 2021 · 2 comments
Closed

Gnome extension brightness-control-using-ddcutil not patched #146926

pp5x opened this issue Nov 21, 2021 · 2 comments
Labels
0.kind: bug Something is broken 6.topic: GNOME GNOME desktop environment and its underlying platform

Comments

@pp5x
Copy link

pp5x commented Nov 21, 2021

Describe the bug

The extension does not work correctly because it can not find /usr/bin/ddcutil in its path. The path is hardcoded in https://github.com/daitj/gnome-display-brightness-ddcutil/blob/master/display-brightness-ddcutil%40themightydeity.github.com/extension.js#L64

The path remain unchanged on my system.

Steps To Reproduce

  1. Enable gnome 3
services.xserver.displayManager.gdm.enable = true;
services.xserver.desktopManager.gnome.enable = true;
  1. Enable ddcutil
environment.systemPackages = with pkgs; [
   ddcutil
   gnomeExtensions.brightness-control-using-ddcutil
];
  1. Gnome extension is not working even though its detected by ddcutil
[pp5x@photon:~]$ ddcutil detect
Display 1
   I2C bus:  /dev/i2c-2
   EDID synopsis:
      Mfg id:               DEL
      Model:                DELL U2412M
      Product code:         41082
      Serial number:        Y1H5T2AT3WNL
      Binary serial number: 861359692 (0x33574e4c)
      Manufacture year:     2012,  Week: 44
   VCP version:         2.1

Side note

Should not the gnome extension also add a dependency to ddcutil and ddcutil to hardware.i2c.enable = true ?

Expected behavior

The extension should show a slider for my display.

Screenshots

image

Additional context

Add any other context about the problem here.

Notify maintainers

@piegamesde

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[pp5x@photon:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.79, NixOS, 21.05.4132.24528474d2b (Okapi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.16`
 - channels(root): `"nixos-21.05.4132.24528474d2b"`
 - channels(pp5x): `"home-manager-21.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
@pp5x pp5x added the 0.kind: bug Something is broken label Nov 21, 2021
@veprbl veprbl added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 21, 2021
@piegamesde
Copy link
Member

Interesting. See #136111, this should have been fixed in #137131. Please make sure you are using that commit and report back.

@pp5x
Copy link
Author

pp5x commented Nov 23, 2021

My bad, indeed it is not available on the stable nixpkgs. I am closing.

Here is the fix in case someone else is running into the same beginner issue.

# configuration.nix
{ config, pkgs, ... }:

let
  unstable = import <nixos-unstable> {};
in {
  environment.systemPackages = with pkgs; [
    unstable.gnomeExtensions.brightness-control-using-ddcutil
  ];
}

@pp5x pp5x closed this as completed Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 6.topic: GNOME GNOME desktop environment and its underlying platform
Projects
None yet
Development

No branches or pull requests

3 participants