Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NixOS 23.11 — Feature Freeze & Release Blockers #259040

Closed
26 of 38 tasks
figsoda opened this issue Oct 4, 2023 · 50 comments
Closed
26 of 38 tasks

NixOS 23.11 — Feature Freeze & Release Blockers #259040

figsoda opened this issue Oct 4, 2023 · 50 comments

Comments

@figsoda
Copy link
Member

figsoda commented Oct 4, 2023

Hi, we are figsoda & Ryan Lahfa, the release managers for NixOS 23.11 ("Tapir").

As we approach the next release of NixOS, it's time to discuss the upcoming feature freeze period. We want to ensure that this release is as stable and reliable as possible, and your contributions are crucial to achieving that goal, here are the two upcoming dates in that context:

  • 2023-10-16: Restrict breaking changes to Release Critical Packages
  • 2023-10-30: Restrict all breaking changes except for desktop environments.

The complete timeline is available here:

The first restriction will be in place in 12 days, therefore, we encourage all teams to check in now and mention possible roadblocks, so we get a good overview of what's ahead.

Blockers

Whether you were pinged or not, we encourage everyone to create issues for release blockers and add them to the 23.11 Blockers project (It is not public yet, so you might not be able to see this if you are not in the organization).

Check-in

Please comment your status quo and possible issues as soon as possible. We'll check teams once they have checked in.

If you think some subsystem, person or team should be added or removed from this list, update maintainers/team-list.nix in time before the next feature freeze announcement.

Desktop environments

Platforms

  • Darwin: @NixOS/darwin-maintainers

Languages ecosystem

Compilers, build systems

Modules

Internals

  • Docs: @asymmetric @ryantm
  • Marketing: @garbas @tomberek
  • Module system: @infinisil @roberth
  • Nix/nix-cli ecosystem: @edolstra @grahamc @nbp
  • NixOS tests: @tfc

Everyone Else

@NixOS/nixpkgs-committers @NixOS/release-engineers

Finally

No issue is too big or too small, but let's remember that we are all working on the project voluntarily in our free time here, so let's focus on issues that can be realistically addressed in the remaining time before the release.

We thank everyone for their contribution!

@figsoda
Copy link
Member Author

figsoda commented Oct 4, 2023

More pings since GitHub limits the amount of pings, please refer to the original issue for the checkboxes

Modules

Internals

@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2023

Python 3.11 is our target major/minor for the upcoming release. The upgrade is currently on staging-next and will arrive on master shortly.

I plan on doing another python-updates cycle before the freeze.

We have no blockers right now.

@RaitoBezarius
Copy link
Member

LLVM here, we have no blockers to the best of my knowledge, LLVM17 is being developed in #258614, I do not plan to push for LLVM17 for this release, it may or may not land in time. We still have technical debt to pay for LLVM git.

@stigtsp
Copy link
Member

stigtsp commented Oct 4, 2023

perlPackages need a major update, I'm working on this.

@ElvishJerricco
Copy link
Contributor

systemd-initrd is of course not a blocker at all, but I would like to try and finally get it feature complete so we can remove the "experimental" wording from the option description before release. It would allow us to start working towards making it the default in a future release. The biggest obstacle to this is probably the unsupported options in luksroot.nix, such as yubikey related things.

@hraban
Copy link
Member

hraban commented Oct 4, 2023

Lisp's SBCL & CLisp are in a good place. Good timing for CLisp actually which just became available on x86_64-darwin and aarch64-darwin.

I'm not involved with the lispPackages scope so I won't speak to that.

@drupol
Copy link
Contributor

drupol commented Oct 4, 2023

No blockers for PHP, this new release will include the new PHP/Composer builder.

@etu
Copy link
Contributor

etu commented Oct 4, 2023

As for PHP we believe it should be good to go, we recently integrated a new project builder which did have some initial bugs that have all been addressed and I believe that we're in a good place as of now 🙂

@NickCao
Copy link
Member

NickCao commented Oct 4, 2023

Qt 6.6 is scheduled to release on 2023/10/10, but since Qt 6.5 is the LTS release, we may keep that for 23.11 as well.

@reckenrode
Copy link
Contributor

I’d like to see the clang 16 bump for Darwin make it for 23.11. The cross stuff would also be a nice bonus. I don’t know how realistic the stdenv stuff is. I’ve been working on it since May, and the update PR has been open since July, but there’s still breakage to fix.

If it the bump doesn’t make 23.11, it can slip to 24.05, but then the plan would be to bump it again to clang 18 in 24.11 (to put Darwin on an annual update cycle). Going to clang 17 for 24.05 isn’t really an option currently because (as far as I know) libc++ 17 dropped support for the 10.12 SDK and requires 10.13.

@OPNA2608
Copy link
Contributor

OPNA2608 commented Oct 4, 2023

Not enough Lomiri DE stuff ended up in Nixpkgs to be usable or have any blockers yet.

@Gabriella439
Copy link
Contributor

No blockers for Dhall

@SuperSandro2000
Copy link
Member

#244742 is a blocker and the workarounds from Ubuntu/Debian will not work for us since we can't predict rebuilds of mesa.

@infinisil
Copy link
Member

No blockers for the module system

@jbedo
Copy link
Contributor

jbedo commented Oct 4, 2023

No blockers for R.

@Alizter
Copy link
Contributor

Alizter commented Oct 4, 2023

OCaml looks to be missing from the list. cc @ulrikstrid @vbgl

@bobby285271
Copy link
Member

bobby285271 commented Oct 5, 2023

We will likely have Cinnamon (5.6 -> 5.8), MATE (1.26), Pantheon (7 -> 7.1), Xfce (4.18) in this release.

GNOME 45 is a WIP. There is no ETA for the merge but the PR is at least basically usable for me.

@ulrikstrid
Copy link
Member

OCaml looks to be missing from the list. cc @ulrikstrid @vbgl

I don't have any blockers on my list for OCaml

@happysalada
Copy link
Contributor

No blockers for beam.
We have a problem with latest macos sonoma but I don't think it's a blocker (especially since we don't have anyone looking into this, since there isn't enough darwin talent).

@RaitoBezarius RaitoBezarius pinned this issue Oct 5, 2023
@jonringer
Copy link
Contributor

jonringer commented Oct 6, 2023

I'm opening up my server to any committer for usage on reviewing nixpkgs PRs. Link to repo. Instructions in README, I'll send you IP + port for ssh access.

Specs:

  • 128T/64C CPU (3990X)
  • 256GB RAM
  • 1 GBit/s down (according to comcast)

@teto
Copy link
Member

teto commented Oct 6, 2023

Nothing blocking really but I want to get into 23.11

  • a refacto to make neovim configuration more discoverable (no breaking change, just leveraging structured attributes)
  • an update of the lua package set that has been blocked by various broken packages on luarocks.org. I've been working towards fixing those for the past few months and the situation has recently been unblocked so I should be able to bump the set next week.

NB: I added those to the board

@Madouura
Copy link
Contributor

Madouura commented Oct 8, 2023

AFAIK the current ROCm derivations and dependents we have work, so there shouldn't be any blockers there.
It would be nice to get #258328 and maybe #259068 in before breaking changes are restricted however.

@wineee
Copy link
Member

wineee commented Oct 8, 2023

deepin desktop v23 stable will not be released until 2024

PR upgrade to v23 beta is ready for review

@figsoda
Copy link
Member Author

figsoda commented Oct 11, 2023

OCaml looks to be missing from the list. cc @ulrikstrid @vbgl

Added. It wasn't included initially because it doesn't have an entry in team-list.nix, #260469 should do the trick

@figsoda
Copy link
Member Author

figsoda commented Oct 11, 2023

No blockers for zig

@asymmetric
Copy link
Contributor

asymmetric commented Oct 14, 2023

@figsoda I think it that for Docs, instead of pinging me, we should ping @NixOS/Documentation-Team

EDIT: I noticed it's due to the membership of docs in team-list.nix, we'll address this within the team.

@minijackson
Copy link
Member

Can ZFS 2.2.0 be part of the 23.11 release? That would be really cool.

@lilyinstarlight
Copy link
Member

I think the only Node.js blocker would have been #260011 since that was a painful problem for some, but that's been merged now. So no blockers from the Node.js team unless @marsam has something

@roberth
Copy link
Member

roberth commented Oct 14, 2023

Node.js

Fetchers suffer from false successes, so I would highly recommend to write automated tests using invalidateFetcherByDrvHash.

EDIT: I didn't find them. I've posted this here to raise awareness of the general issue with fetchers, but it seems that in this specific case it wasn't necessary.

@lilyinstarlight
Copy link
Member

Fetchers suffer from false successes, so I would highly recommend to write automated tests using invalidateFetcherByDrvHash.

It already has several tests that use that exact function. Do you have specific tests you feel it needs added to these? (Also it might be best to open a new issue to avoid noise on this thread about 23.11)

@toonn
Copy link
Contributor

toonn commented Oct 19, 2023

@figsoda, @RaitoBezarius, we merged the LLVM bump so it no longer holds up the schedule.

@figsoda
Copy link
Member Author

figsoda commented Oct 23, 2023

Feature freeze is scheduled to be in exactly 1 week (2023-10-30). If you have any breaking changes you want to see in 23.11, feel free to request reviews and try to get them merged in time!

@mweinelt
Copy link
Member

We need a fix for the regressions around the postgresql 15 bump and ensureUsers.

#216989

@wineee
Copy link
Member

wineee commented Oct 26, 2023

As For DDE(deepin desktop environment)

DDE 20 is not maintained by deepin currently, and most components will not get updated

DDE 23 is still in beta release and there will be no stable version in the short term. Beta 3 will be released next year, and it is likely that the stable version will be available in 2025.
Many components are being rewritten or ready to be rewritten, such as a new window manager based on wlroots, new dock/launcher/control-center based on qml, abandon go package and use c++ to reimplement...

archlinux and UbuntuDDE have ported DDE 23, and I tend not to wait for stable to be released. This will take too long as DDE 20 is already outdated

Actually, I don't want to block 23.11 Release. It would be acceptable to merge on 24.05 (unstable), but I do need to request reviews. The effective feedback received of PR #257400 is too few

@Yarny0
Copy link
Contributor

Yarny0 commented Oct 27, 2023

If you have any breaking changes you want to see in 23.11, feel free to request reviews and try to get them merged in time!

It would be nice to have this RFC 42 migration in the next release: #253428

@the-furry-hubofeverything
Copy link
Contributor

Feature freeze is scheduled to be in exactly 1 week (2023-10-30). If you have any breaking changes you want to see in 23.11, feel free to request reviews and try to get them merged in time!

It may seem impatient (since I recently got reviews), but It's almost 2 days away from feature freeze and I would really like to see my PR merged (#257780). It's been in the works since the beginning of the month, and maintainers haven't responded for more than two weeks since I asked for reviews.

It introduces multiple blender versions to be included in nixpkgs, since Blender usually release a latest version, and LTS versions that are actively maintained for two years.

This PR also includes a breaking change, where it removes blender-with-packages in favor of blender.withPackages, since the inputs are reworked and incompatible with the current usage of blender-with-packages.

This change is important because previously, blender-with-packages doesn't provide a way to track the pythonPackages used, something like blender-with-packages { packages = with blender.python.pkgs; [ bpycv ]; }. This could be an issue with multiple blender versions, since different versions of blender could use different versions of python, depending on which VFX reference platform blender is tracking for that version.

Blender LTS versions lasts two years, so it's highly likely that two different versions of blender uses two different versions of python.

Another drawback of the current implementation is that users might use something like blender-with-packages { packages = with python3.pythonPackages; [ bpycv ]; }, which might not match blender's pythonPackage scope (blender 3.3 and 3.6 uses 3.10, future versions that track VFX reference CY2024 would use 3.11).

My original plan is to point blender-with-packages to the latest version of blender.withPackages, but with this change, previous configurations wouldn't work with it anyway, so might as well remove it.

This PR reworks blender-with-packages to blender.withPackges - which can be used similar to how python.withPackages is used, and it's more specific to the version of blender used, for example blenderVersions.blender_3_3.withPackages(ps: [ ps.bpycv ])

@Yarny0
Copy link
Contributor

Yarny0 commented Oct 29, 2023

Feature freeze is scheduled to be in exactly 1 week (2023-10-30). If you have any breaking changes you want to see in 23.11, feel free to request reviews and try to get them merged in time!

#261319 fixes user-controlled lingering which got broken by #260248 .

@figsoda
Copy link
Member Author

figsoda commented Oct 30, 2023

It may seem impatient (since I recently got reviews), but It's almost 2 days away from feature freeze and I would really like to see my PR merged (#257780).

No worries!

Looking at the changes, looks like the only breaking change is blender-with-packages -> blender.withPackages. If you think it might make it easier to review, taking this out into a new PR could be an option, and the rest of the changes can go in after feature freeze.

Great work on the PR, I would love to see it in 23.11!

@the-furry-hubofeverything
Copy link
Contributor

No worries!

Looking at the changes, looks like the only breaking change is blender-with-packages -> blender.withPackages. If you think it might make it easier to review, taking this out into a new PR could be an option, and the rest of the changes can go in after feature freeze.

Great work on the PR, I would love to see it in 23.11!

#264292

@happysalada
Copy link
Contributor

should the change of default of nodejs from 18 to 20 be included ? #262837
(upstream switched lts to 20 end of october).

@nbraud
Copy link
Contributor

nbraud commented Nov 7, 2023

Not sure here's the correct place to bring this up, but the sudo module doesn't currently match the documented changes (in release notes) due to the partial revert/split in #256491.

#262790 fixes this, but it's been sitting idle for the last 2 weeks with a single review and no merge.
Update: merged today, thanks everyone.

@stigtsp
Copy link
Member

stigtsp commented Nov 21, 2023

No blockers for Perl :)

@Madouura
Copy link
Contributor

Madouura commented Nov 21, 2023

We should probably get #268746 in when it's approved if branch-off still hasn't happened.
Strict fix/improvement.

@SuperSandro2000
Copy link
Member

should the change of default of nodejs from 18 to 20 be included

I think it is a bit late for changing the default version of a big interpreter this late.

@vcunat
Copy link
Member

vcunat commented Nov 22, 2023

23.11 was branched off several hours ago (for reference), so adding more features seems quite unlikely anymore and focus should be on bufixing/stabilization.

@infinisil
Copy link
Member

#244742 is a blocker and the workarounds from Ubuntu/Debian will not work for us since we can't predict rebuilds of mesa.

I want to highlight this. After updating today I just ran into this problem with slack (though there an update seems to resolve it) and Elements (this exact issue: #261997). This is pretty terrible because it breaks the main application people are using to chat in the Nix community for maybe almost everyone.

@SuperSandro2000
Copy link
Member

This was fixed for chromium and electron releases. I am not sure which version exactly but programs that vendor electron are maybe still affected. The ones using electron 25+ are in my experience no longer affected.

@atopuzov
Copy link
Contributor

Hey not sure where to bring this up. ttyd service needs a fix for 23.11 #268504 due to changes in ttyd 1.7.4 that make it read only by default. Thanks.

@Xyz00777
Copy link
Contributor

Xyz00777 commented Dec 1, 2023

#244742 is a blocker and the workarounds from Ubuntu/Debian will not work for us since we can't predict rebuilds of mesa.

I want to highlight this. After updating today I just ran into this problem with slack (though there an update seems to resolve it) and Elements (this exact issue: #261997). This is pretty terrible because it breaks the main application people are using to chat in the Nix community for maybe almost everyone.

it also had broken my Bitwarden and Obsidian, fixed with removing the old GPU Shaders but still it was really confusing...

@figsoda
Copy link
Member Author

figsoda commented Dec 1, 2023

NixOS 23.11 has been released on 2023-11-29. For issues that are not yet resolved, feel free to open new issues.

@figsoda figsoda closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests