-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package: update vdirsyncer to account for the new rust dependancy #33050
Comments
I'm on it. |
Ok. This will get messy and ugly... I doubt that I will succeed in this, especially as I do not have the resources to build rustc from source right now. Maybe @jgeerds can come up with a good idea. |
It's super hacky but at least this manages to build - https://github.com/NixOS/nixpkgs/compare/master...pbogdan:pr_33052?expand=1 (based on the referenced PR). |
Thanks for the help boys ! I tried the patch which fails on
|
Was that from my branch? I thought https://github.com/NixOS/nixpkgs/compare/master...pbogdan:pr_33052?expand=1#diff-fa94f0db0527b004ae3809fa214083a0R40 ought to prevent that and the rust part would be built separately. |
Right my bad. I freaked out when I clicked on your link that proposed to create a new PR so I clicked away, and I ended up testing matthias PR :< I tested yours which goes a bit farther. I ve tried twice with the same error. I am in sandboxed mode on ixos-unstable so that might be why ? I can try rerunning with RUST_BACKTRACE=1 if that helps. Thanks for your work.
|
Yes, unfortunately rustc seems to panic quite a lot in nondeterministic fashion :-(. I'm not sure why that is but I eventually succeeded building the package (with sandboxing enabled) after retrying a few times. |
Indeed it crashes at different steps yet I could not reach the end of the build progress despite many attempts. I guess I need to pay attention for newer rust versions too.
then
etc so that once vdirsyncer installs dependancies they are already compiled. |
This is being widely reported, especially under Nix for some reason. See rust-lang/rust#46981 |
I am working on this, it appears to be that our rust build is using an outdated version of the jobserver crate which had this bug. |
@pbogdan after successfully installing another rsut-based package, I tried your patch and it worked. |
@bennofs any news :) ? |
@teto I think this should be fixed on master, since it uses a newer rustc release (1.24) |
PR merged. Thanks for your help |
Issue description
I am having some issues with vdirsyncer pimutils/vdirsyncer#691, the author asked me to test the latest version so I looked into upgrading the package but the setup.py seems to compile a rust shared library so I am not sure how to tackle that (and I don't know rust):
https://github.com/pimutils/vdirsyncer/blob/master/setup.py#L41
I believe it would be best if nix could build the rust dependancy separately but I am not sure enough to actually ask vdirsyncer author to change that just for nixos.
@matthiasbeyer @jgeerds
The text was updated successfully, but these errors were encountered: