Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink all-packages.nix #39561

Closed
1 of 9 tasks
matthewbauer opened this issue Apr 26, 2018 · 2 comments
Closed
1 of 9 tasks

Shrink all-packages.nix #39561

matthewbauer opened this issue Apr 26, 2018 · 2 comments

Comments

@matthewbauer
Copy link
Member

matthewbauer commented Apr 26, 2018

Issue description

I think everyone agrees that all-packages.nix has become too difficult to maintain. I hope we can look into moving some of it into separate files. My goal would be to get it to under 15,000 lines which is the max GitHub will display. Right now it is 21,380 lines. This is related to #39169.

Easy changes

  • Merge common "inherit (x)" uses
  • Move "nixpkgs.windows" attribute to its own file
  • Move "nixpkgs.linuxPackagesFor" to its own file
  • Move "nixpkgs.tests" to its own file
  • Get rid of legacy "emacsPackagesGen" stuff (emacsPackagesNg has replaced it)
  • Move some aliases to aliases.nix
  • Move fetchFromGitHub to its own file.

Hard changes

@oxij
Copy link
Member

oxij commented Apr 26, 2018

  • Autogenerate pkgs/package-list.nix and use that as a base for most of what pkgs/top-level/all-packages.nix now does.

@CMCDragonkai
Copy link
Member

Maybe even alphabetically order it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants