Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.zope.interface: 5.1.0 -> 5.1.2 #110868

Merged
merged 1 commit into from
Jan 29, 2021
Merged

[20.09] python3Packages.zope.interface: 5.1.0 -> 5.1.2 #110868

merged 1 commit into from
Jan 29, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 26, 2021

(cherry picked from commit ee7591e)

Motivation for this change

matrix-org/synapse#7176

cc @Ma27 @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jan 26, 2021

👍 for the backport then.

@ofborg ofborg bot requested a review from cillianderoiste January 26, 2021 17:56
Ma27
Ma27 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops sorry forgot to merge!

@Ma27 Ma27 merged commit a4ea9cf into NixOS:staging-20.09 Jan 29, 2021
@ajs124 ajs124 deleted the backport/20.09/zope.interface branch January 29, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajs124 @Ma27 @FRidh