Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.ufolib2: rename from ufoLib2 #279352

Merged
merged 1 commit into from
Jan 8, 2024
Merged

python311Packages.ufolib2: rename from ufoLib2 #279352

merged 1 commit into from
Jan 8, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Jan 7, 2024 •
edited
Loading

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Jan 7, 2024
Closed
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 279352 run on x86_64-linux 1

50 packages built:
  • fontbakery (python311Packages.fontbakery)
  • fontbakery.dist (python311Packages.fontbakery.dist)
  • nanoemoji
  • nanoemoji.dist
  • python310Packages.babelfont
  • python310Packages.babelfont.dist
  • python310Packages.collidoscope
  • python310Packages.collidoscope.dist
  • python310Packages.fontbakery
  • python310Packages.fontbakery.dist
  • python310Packages.fontfeatures
  • python310Packages.fontfeatures.dist
  • python310Packages.fontmake
  • python310Packages.fontmake.dist
  • python310Packages.glyphsets
  • python310Packages.glyphsets.dist
  • python310Packages.glyphslib
  • python310Packages.glyphslib.dist
  • python310Packages.glyphtools
  • python310Packages.glyphtools.dist
  • python310Packages.shaperglot
  • python310Packages.shaperglot.dist
  • python310Packages.statmake
  • python310Packages.statmake.dist
  • python310Packages.ufo2ft
  • python310Packages.ufo2ft.dist
  • python310Packages.ufolib2
  • python310Packages.ufolib2.dist
  • python311Packages.babelfont
  • python311Packages.babelfont.dist
  • python311Packages.collidoscope
  • python311Packages.collidoscope.dist
  • python311Packages.fontfeatures
  • python311Packages.fontfeatures.dist
  • python311Packages.fontmake
  • python311Packages.fontmake.dist
  • python311Packages.glyphsets
  • python311Packages.glyphsets.dist
  • python311Packages.glyphslib
  • python311Packages.glyphslib.dist
  • python311Packages.glyphtools
  • python311Packages.glyphtools.dist
  • shaperglot (python311Packages.shaperglot)
  • shaperglot.dist (python311Packages.shaperglot.dist)
  • python311Packages.statmake
  • python311Packages.statmake.dist
  • python311Packages.ufo2ft
  • python311Packages.ufo2ft.dist
  • python311Packages.ufolib2
  • python311Packages.ufolib2.dist

@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 7, 2024 12:31
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jan 7, 2024
@ofborg ofborg bot requested a review from barinov274 January 7, 2024 13:05
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 7, 2024
@doronbehar doronbehar merged commit 39899b4 into NixOS:master Jan 8, 2024
30 checks passed
@Stunkymonkey Stunkymonkey deleted the ufolib2-normalize branch January 17, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danc86 danc86 danc86 approved these changes

@999eagle 999eagle Awaiting requested review from 999eagle

@doronbehar doronbehar Awaiting requested review from doronbehar

@barinov274 barinov274 Awaiting requested review from barinov274

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stunkymonkey @danc86 @delroth @doronbehar