vimPlugins.clang_complete, vimPlugins.clighter8: use default `llvmPac… #279576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kages` Old `llvmPackages_6` has only two users in `nixpkgs`. It has a few issues like incomplete support for building `pkgsLLVM.clang_6`. It would be nice to remove `llvmPackages_6` frm `nixpkgs`. Let's switch `vimPlugins` to a default `llvmPackages`. `clang_complete` should work as is. Don't know about `clighter8`.
|
Result of 2 packages built:
|
SuperSandro2000
approved these changes
Jan 8, 2024
delroth
added
the
12.approvals: 1
13 tasks
delroth
added
12.approvals: 2
wegank
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
I wonder how clighter8 could work given that it depends on Python 2...
delroth
added
12.approvals: 3+
thiagokokada
approved these changes
Jan 9, 2024
wegank
pushed a commit
to trofi/nixpkgs
that referenced
this pull request
Jan 9, 2024
Remove all the aliases for `llvmPackages_6` except the `llvmPackages_6` itself. We can remove `llvmPackages_6` once last two users are gone: - vimPlugins: NixOS#279576 - beignet: NixOS#279578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kages`
Old
llvmPackages_6has only two users innixpkgs. It has a few issues like incomplete support for buildingpkgsLLVM.clang_6. It would be nice to removellvmPackages_6frmnixpkgs.Let's switch
vimPluginsto a defaultllvmPackages.clang_completeshould work as is. Don't know aboutclighter8.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.