-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beignet: remove the package #279578
Merged
Merged
beignet: remove the package #279578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`beignet` saw no development since 2018 and was never ported from `llvmPackages_6`. Is it's a library to support `OpenCL` on older GPUs let's drop it from `nixpkgs`.
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: documentation
This PR adds or changes documentation
labels
Jan 8, 2024
SuperSandro2000
approved these changes
Jan 8, 2024
Result of 1 package blacklisted:
|
delroth
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Jan 8, 2024
13 tasks
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Jan 8, 2024
Also @artuuge, since I can't add them to the reviewers. |
philiptaron
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, five years is long enough.
delroth
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Jan 8, 2024
wegank
pushed a commit
to trofi/nixpkgs
that referenced
this pull request
Jan 9, 2024
Remove all the aliases for `llvmPackages_6` except the `llvmPackages_6` itself. We can remove `llvmPackages_6` once last two users are gone: - vimPlugins: NixOS#279576 - beignet: NixOS#279578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: clean-up
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
12.approvals: 2
This PR was reviewed and approved by two reputable people
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beignet
saw no development since 2018 and was never ported fromllvmPackages_6
. Is it's a library to supportOpenCL
on older GPUs let's drop it fromnixpkgs
.Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.