Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beignet: remove the package #279578

Merged
merged 1 commit into from
Jan 9, 2024
Merged

beignet: remove the package #279578

merged 1 commit into from
Jan 9, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 8, 2024

beignet saw no development since 2018 and was never ported from llvmPackages_6. Is it's a library to support OpenCL on older GPUs let's drop it from nixpkgs.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

`beignet` saw no development since 2018 and was never ported from
`llvmPackages_6`. Is it's a library to support `OpenCL` on older GPUs
let's drop it from `nixpkgs`.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation labels Jan 8, 2024
@trofi
Copy link
Contributor Author

trofi commented Jan 8, 2024

Result of nixpkgs-review pr 279578 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 8, 2024
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 8, 2024
@wegank wegank requested a review from zimbatm January 8, 2024 12:52
@wegank
Copy link
Member

wegank commented Jan 8, 2024

Also @artuuge, since I can't add them to the reviewers.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, five years is long enough.

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 8, 2024
@zimbatm zimbatm merged commit 3f77dbd into NixOS:master Jan 9, 2024
26 checks passed
@trofi trofi deleted the beignet-drop branch January 9, 2024 09:00
wegank pushed a commit to trofi/nixpkgs that referenced this pull request Jan 9, 2024
Remove all the aliases for `llvmPackages_6` except the `llvmPackages_6`
itself.

We can remove `llvmPackages_6` once last two users are gone:

- vimPlugins: NixOS#279576
- beignet: NixOS#279578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants