Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsMusl.bun: mark broken for musl #280717

Merged
merged 1 commit into from
Jan 16, 2024
Merged

pkgsMusl.bun: mark broken for musl #280717

merged 1 commit into from
Jan 16, 2024

Conversation

superherointj
Copy link
Contributor

pkgsMusl.bun: mark broken for musl

Tracking issue: #280716

ping bun maintainers: @DAlperin @jk @thilobillerbeck @cdmistman @coffeeispower

thilobillerbeck
thilobillerbeck suggested changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@thilobillerbeck thilobillerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thats unfortunate, hopefully we can find a solution there. Marking it as broken for now seems like a good solution. If you could fix up the date in the comment this will be fine. 👍

pkgs/development/web/bun/default.nix Outdated Show resolved Hide resolved
@superherointj superherointj force-pushed the pkgsMusl-bun-mark-broken branch from 986ce12 to f0f94e7 Compare January 13, 2024 14:26
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 13, 2024
cdmistman
cdmistman approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@cdmistman cdmistman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@GetPsyched GetPsyched added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 14, 2024
@thilobillerbeck thilobillerbeck self-requested a review January 15, 2024 20:57
@delroth delroth added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jan 15, 2024
@fpletz fpletz merged commit 5a43ec5 into NixOS:master Jan 16, 2024
22 checks passed
@superherointj superherointj deleted the pkgsMusl-bun-mark-broken branch January 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GetPsyched GetPsyched GetPsyched approved these changes

@cdmistman cdmistman cdmistman approved these changes

@thilobillerbeck thilobillerbeck thilobillerbeck approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@superherointj @thilobillerbeck @cdmistman @GetPsyched @fpletz @delroth