Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rwpspread: init at 0.1.8 #284144

Merged
merged 2 commits into from
Feb 12, 2024
Merged

rwpspread: init at 0.1.8 #284144

merged 2 commits into from
Feb 12, 2024

Conversation

fsnkty
Copy link
Member

@fsnkty fsnkty commented Jan 27, 2024

Description of changes

Added rwpspread a multi monitor wallpaper utility for use on wlroots based compositors

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fsnkty fsnkty force-pushed the init-rwpspread branch 2 times, most recently from e4ea5d0 to 7e94a6b Compare January 27, 2024 01:06
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Added some feedback below.

pkgs/by-name/rw/rwpspread/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rw/rwpspread/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rw/rwpspread/package.nix Show resolved Hide resolved
pkgs/by-name/rw/rwpspread/package.nix Show resolved Hide resolved
pkgs/by-name/rw/rwpspread/package.nix Outdated Show resolved Hide resolved
@eclairevoyant eclairevoyant added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 27, 2024
@fsnkty fsnkty force-pushed the init-rwpspread branch 2 times, most recently from 908aa0d to 340a609 Compare January 27, 2024 01:35
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, seems to work fine. The wpaperd integration is weird but I would blame that on the other app. Integration works fine as well.

@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 27, 2024
@fsnkty
Copy link
Member Author

fsnkty commented Jan 27, 2024

reverting the change of sourcing the Cargo lock file direct from source as eval here failed.
worked fine locally so would love to see if there's some way to avoid including that big lock-file separately as I do now.

@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 27, 2024
@eclairevoyant eclairevoyant added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 27, 2024
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 27, 2024
@eclairevoyant eclairevoyant self-requested a review January 27, 2024 10:43
@eclairevoyant eclairevoyant added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jan 28, 2024
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 28, 2024
@raspher
Copy link
Member

raspher commented Jan 29, 2024

Result of nixpkgs-review pr 284144 run on aarch64-linux 1

1 package built:
  • rwpspread

@SuperSandro2000 SuperSandro2000 merged commit b05b56d into NixOS:master Feb 12, 2024
31 checks passed
@fsnkty fsnkty deleted the init-rwpspread branch February 13, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants