-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages luarocks updater as pyproject package #343584
packages luarocks updater as pyproject package #343584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, have you been able to test it ?
so we can copy just the folder when using this as a module
d1f5730
to
78010e9
Compare
Ofc I've tested it :D if you merge, I thinkg all commits can be squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this !
Result of 3 packages built:
|
Description of changes
Extracted from #342884
This made it easier to set as a python dependency of the neovim updater + pyproject has the advantage that we can configure the linting in it for more coherence between contributors.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.