pluginupdate.py: fix bugs and add improvements; vimPlugins: sort properly #353786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix-owners
bot
requested review from
figsoda,
GaetanLepage,
khaneliman,
manveru,
mrcjkb,
philiptaron,
rvolosatovs and
teto
PerchunPak
force-pushed
the
fixes-for-pluginsupdate
branch
from
08a39df to
a58e7d3
Compare
17 tasks
PerchunPak
force-pushed
the
fixes-for-pluginsupdate
branch
from
a58e7d3 to
cb15b92
Compare
|
Thank you for this ! |
Ruff - an extremely fast Python linter and code formatter, written in Rust.
I fixed many hidden bugs and made some small improvements. The main reason this was separated from NixOS#336137 is to fix the sorting issue. Before this commit, sorting for Vim plugins was broken and worked by what was fetched first. This is because the sorting was done by empty strings (the default value in CSV is not None but an empty string). This PR fixes it and also moves sorting from the user to the library (from `vim/plugins/update.py` to `pluginupdate.py`) to prevent such weird issues and duplication of code.
PerchunPak
force-pushed
the
fixes-for-pluginsupdate
branch
from
cb15b92 to
e9b1d2d
Compare
PerchunPak
commented
Nov 8, 2024
| sys.path.insert( | ||
| 0, os.path.join(ROOT.parent.parent.parent.parent.parent, "maintainers", "scripts") | ||
| ) | ||
| import pluginupdate | ||
|
|
||
| GET_PLUGINS = f"""(with import <localpkgs> {{}}; | ||
| GET_PLUGINS = f"""( | ||
| with import <localpkgs> {{ }}; |
There was a problem hiding this comment.
I also manually formatted this with nixfmt-rfc-style
GaetanLepage
reviewed
Nov 8, 2024
| @@ -50,7 +50,7 @@ | |||
| lib.filterAttrs (n: v: v != null) checksums | |||
| )""" | |||
|
|
|||
| HEADER = "# This file has been generated by ./pkgs/applications/editors/kakoune/plugins/update.py. Do not edit!" | |||
| HEADER = "# This file has been @generated by ./pkgs/applications/editors/kakoune/plugins/update.py. Do not edit!" | |||
There was a problem hiding this comment.
Just saw that the same does poetry
khaneliman
approved these changes
Nov 9, 2024
khaneliman
changed the title
|
|
ran it locally. Seemed ok. |
|
thanks for the work. Now onto single plugin updates :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed many hidden bugs and made some small improvements. The main reason this was separated from #336137 is to fix the sorting issue.
Before this commit, sorting for Vim plugins was broken and worked by what was fetched first. This is because the sorting was done by empty strings (the default value in CSV is not None but an empty string). This PR fixes it and also moves sorting from the user to the library (from
vim/plugins/update.pytopluginupdate.py) to prevent such weird issues and duplication of code.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)CC @NixOS/neovim
Add a 👍 reaction to pull requests you find important.