autoconf-archive: fix quoting of m4_fatal

[corngood]

This fixes the cava package, and could potentially fix others. I tested this as an override in cava and it worked, but I haven't built this in staging.

I believe it was broken by 59b91ba.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jopejoe1]

Getting a hash mismatch

error: hash mismatch in fixed-output derivation '/nix/store/a0avdgs7l859rlxcb2z6y63a5kq5fsc4-ax_check_gl-fix.patch.drv':
        likely URL: https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=patch;h=427e226a2fe3980388abffd6de25ed6b9591cce3
         specified: sha256-ajmyhz7boaRsM6wfLuKkZMo6pC53FwABX6p6ZcsoMV8=
            got:    sha256-gQbfXqfhpjjsUek6A4xqmnHdKPayhZhcXk6o4O+7Iqo=

[corngood]

Ah, sorry, that was because I started with an override using fetchpatch, and changed it to fetchurl + explicit name here. Only the name would have differed. Fixed.

[jopejoe1]

Tested building a few packages with this.

[Scrumplex]

what is the reason for using fetchurl here? fetchpatch/fetchpatch2 should be preferred when fetching patches generated by git frontends

[corngood]

I believe there's some bootstrap context where this package is evaluated, but fetchpatch is broken. I think because the bootstrap fetchurl is incompatible with it? It's easy to repro by evaluating this package for linux with the change.

[Scrumplex]

If there would be a circular dependency with a fetcher, we generally include patches directly in Nixpkgs. Using fetchurl for patches means that the patch might become unreproducible if the upstream service changes

[corngood]

I've updated this to include the patches in nixpkgs. There were two other similar patches that were merged together, so I grabbed them all.

I think that's a good idea given these are small and it's a critical package.

[corngood]

In gentoo they apparently just hacked cava to work-around this: https://bugs.gentoo.org/941845

Given how infrequently autoconf-archive is updated, and the possibility of this breaking other packages, I think it still might be a good idea to fix it here.

[github-actions]

Successfully created backport PR for staging-24.11:

• [Backport staging-24.11] autoconf-archive: fix quoting of m4_fatal #356667

[Hisui02]

When is this going to be available in unstable branch?

[vcunat]

My hope is that this weekend we can get it into 24.11 and soon afterwards into master (nixos-ustable, etc.)