Enables extra parameters to be passed to the model load function. #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction
# Summary:
When someone trains a model using a GPU and then tries to this model on a machine with CPUs only. They are presented with the following error message
```
RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.
```
If one specifies the following:
```
MODEL_FILENAME_DICT[model_name].load_from_checkpoint(f"{path}/{model}", map_location=torch.device('cpu'))
```
The error is remedied.
This PR generalizes the error above, by allowing users to pass additional arguments to the `load_from_checkpoint` to avoid such complications.
|
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cchallu
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When someone trains a model using a GPU and then tries to load this model on a machine with CPUs only. They are presented with the following error message
If one specifies the following:
The error is remedied.
This PR generalizes the error above, by allowing users to pass additional arguments to the
load_from_checkpointto avoid such complications.See also the slack conversation https://nixtlacommunity.slack.com/archives/C031M8RLC66/p1692912462083859
for more details.